fixes per review

[hackapet/Adafruit_Blinka.git] / src / busio.py

diff --git a/src/busio.py b/src/busio.py
index 9d9f52a0bd7fb402ec21374d57cd5192936fde8c..ec9f6589350fdd690e087a04718a7ddcaf751f20 100644 (file)
--- a/src/busio.py
+++ b/src/busio.py
@@ -9,6 +9,7 @@ See `CircuitPython:busio` in CircuitPython for more details.
 
 * Author(s): cefn
 """
+import os
 
 try:
     import threading
@@ -50,8 +51,10 @@ class I2C(Lockable):
             self._i2c = _I2C(frequency=frequency)
             return
         if detector.board.microchip_mcp2221:
-            from adafruit_blinka.microcontroller.mcp2221.i2c import I2C as _I2C
-
+            if "BLINKA_FORCECHIP" in os.environ and os.environ["BLINKA_FORCEBOARD"] == "MICROCHIP_MCP2221":
+                from adafruit_blinka.microcontroller.fake_mcp2221.i2c import I2C as _I2C
+            else:
+                from adafruit_blinka.microcontroller.mcp2221.i2c import I2C as _I2C
             self._i2c = _I2C(frequency=frequency)
             return
         if detector.board.greatfet_one:
@@ -138,8 +141,9 @@ class I2C(Lockable):
 
         if detector.board.any_embedded_linux:
             from adafruit_blinka.microcontroller.generic_linux.i2c import I2C as _I2C
+
             if frequency == 100000:
-                frequency = None    # Set to None if default to avoid triggering warning
+                frequency = None  # Set to None if default to avoid triggering warning
         elif detector.board.ftdi_ft2232h:
             from adafruit_blinka.microcontroller.ftdi_mpsse.mpsse.i2c import I2C as _I2C
         else:
@@ -193,18 +197,17 @@ class I2C(Lockable):
             if end is None:
                 end = len(buffer)
             buffer = memoryview(buffer)[start:end]
-        stop = True  # remove for efficiency later
-        return self._i2c.readfrom_into(address, buffer, stop=stop)
+        return self._i2c.readfrom_into(address, buffer, stop=True)
 
-    def writeto(self, address, buffer, *, start=0, end=None, stop=True):
+    def writeto(self, address, buffer, *, start=0, end=None):
         """Write to a device at specified address from a buffer"""
         if isinstance(buffer, str):
             buffer = bytes([ord(x) for x in buffer])
         if start != 0 or end is not None:
             if end is None:
-                return self._i2c.writeto(address, memoryview(buffer)[start:], stop=stop)
-            return self._i2c.writeto(address, memoryview(buffer)[start:end], stop=stop)
-        return self._i2c.writeto(address, buffer, stop=stop)
+                return self._i2c.writeto(address, memoryview(buffer)[start:], stop=True)
+            return self._i2c.writeto(address, memoryview(buffer)[start:end], stop=True)
+        return self._i2c.writeto(address, buffer, stop=True)
 
     def writeto_then_readfrom(
         self,