From 5f6bb4e415c72e5d416da99a1b116de1644bcff5 Mon Sep 17 00:00:00 2001 From: Cefn Hoile Date: Sun, 25 Feb 2018 00:07:29 +0000 Subject: [PATCH] Renaming and refactoring typos. Experimental logic for board-based Pin naming, falling back on microcontroller-based Pin naming --- src/adafruit_blinka/__init__.py | 2 +- src/adafruit_blinka/board/feather_m0_express.py | 0 src/adafruit_blinka/board/nodemcu.py | 4 ++-- src/adafruit_blinka/board/pyboard.py | 2 +- src/bitbangio.py | 1 - src/board.py | 8 +++----- src/microcontroller.py | 17 ++++++++++++++--- 7 files changed, 21 insertions(+), 13 deletions(-) delete mode 100644 src/adafruit_blinka/board/feather_m0_express.py diff --git a/src/adafruit_blinka/__init__.py b/src/adafruit_blinka/__init__.py index 0e52a3c..32b2002 100644 --- a/src/adafruit_blinka/__init__.py +++ b/src/adafruit_blinka/__init__.py @@ -37,7 +37,7 @@ class ContextManaged: def __exit__(self, exc_type, exc_value, traceback): self.deinit() -def Lockable(ContextManaged): +class Lockable(ContextManaged): _locked = False def try_lock(self): diff --git a/src/adafruit_blinka/board/feather_m0_express.py b/src/adafruit_blinka/board/feather_m0_express.py deleted file mode 100644 index e69de29..0000000 diff --git a/src/adafruit_blinka/board/nodemcu.py b/src/adafruit_blinka/board/nodemcu.py index 9419134..83e4ca8 100644 --- a/src/adafruit_blinka/board/nodemcu.py +++ b/src/adafruit_blinka/board/nodemcu.py @@ -1,4 +1,4 @@ -from microcontroller import pin +from adafruit_blinka.microcontroller.esp8266 import pin D0 = pin.GPIO16 D1 = pin.GPIO5 @@ -26,4 +26,4 @@ RX0 = D9 TX0 = D10 # GPIO0 and GPIO2 have built-in pull-ups on common ESP8266 -# breakout boards making them suitable for I2C SDA and SCL +# breakout boards making them suitable for I2C SDA and SCL \ No newline at end of file diff --git a/src/adafruit_blinka/board/pyboard.py b/src/adafruit_blinka/board/pyboard.py index 8c04873..f5a5b0c 100644 --- a/src/adafruit_blinka/board/pyboard.py +++ b/src/adafruit_blinka/board/pyboard.py @@ -1,4 +1,4 @@ -from microcontroller import pin +from adafruit_blinka.microcontroller.stm32 import pin X1=pin.A0 X2=pin.A1 diff --git a/src/bitbangio.py b/src/bitbangio.py index 8f9635b..0dbeb82 100644 --- a/src/bitbangio.py +++ b/src/bitbangio.py @@ -5,7 +5,6 @@ from machine import Pin class I2C(Lockable): def __init__(self, scl, sda, frequency=400000): - super().__init() self.init(scl, sda, frequency) def init(self, scl, sda, frequency): diff --git a/src/board.py b/src/board.py index 707c643..cd0390b 100644 --- a/src/board.py +++ b/src/board.py @@ -39,13 +39,11 @@ __repo__ = "https://github.com/adafruit/Adafruit_Micropython_Blinka.git" if board == "feather_huzzah": - pass -elif board == "feather_m0_express": - pass + from adafruit_blinka.board.feather_huzzah import * elif board == "nodemcu": - pass + from adafruit_blinka.board.nodemcu import * elif board == "pyboard": - pass + from adafruit_blinka.board.pyboard import * else: raise NotImplementedError("Board not supported") gc.collect() \ No newline at end of file diff --git a/src/microcontroller.py b/src/microcontroller.py index c34511a..0daf1c5 100644 --- a/src/microcontroller.py +++ b/src/microcontroller.py @@ -5,11 +5,22 @@ class Pin(Enum): def __init__(self, id): """Identifier for pin, referencing platform-specific pin id""" self.id = id - pass + + def __repr__(self): + import board + for key in dir(board): + if getattr(board, key) is self: + return "board.{}".format(key) + import microcontroller + for key in dir(microcontroller): + if getattr(microcontroller, key) is self: + return "microcontroller.{}".format(key) + return repr(self) + if agnostic.microcontroller == "esp8266": - pass + from adafruit_blinka.microcontroller.esp8266 import * elif agnostic.microcontroller == "stm32": - pass + from adafruit_blinka.microcontroller.stm32 import * else: raise NotImplementedError("Microcontroller not supported") \ No newline at end of file -- 2.49.0