From: brentru Date: Tue, 21 May 2024 17:58:35 +0000 (-0400) Subject: linten more X-Git-Tag: 8.39.2^2~2 X-Git-Url: https://git.ayoreis.com/Adafruit_Blinka-hackapet.git/commitdiff_plain/ac3a61b18e4f2e4994970e07a1dff129bababd62 linten more --- diff --git a/tests/test_generic_agnostic_board_analogio.py b/tests/test_generic_agnostic_board_analogio.py index dee83e9..b48a383 100644 --- a/tests/test_generic_agnostic_board_analogio.py +++ b/tests/test_generic_agnostic_board_analogio.py @@ -1,7 +1,7 @@ # SPDX-FileCopyrightText: 2024 Brent Rubell for Adafruit Industries # # SPDX-License-Identifier: MIT -import pytest +import pytest # pylint: disable=unused-import import board import analogio diff --git a/tests/test_generic_agnostic_board_digitalio.py b/tests/test_generic_agnostic_board_digitalio.py index feb1f5b..492c24f 100644 --- a/tests/test_generic_agnostic_board_digitalio.py +++ b/tests/test_generic_agnostic_board_digitalio.py @@ -15,9 +15,9 @@ def test_Dx_OUTPUT_TRUE(): pin_out.direction = digitalio.Direction.OUTPUT # Test setting the value and reading it back pin_out.value = True - assert pin_out.value == True + assert pin_out.value is True pin_out.value = False - assert pin_out.value == True + assert pin_out.value is True pin_out.deinit() @@ -29,8 +29,8 @@ def test_Dx_INPUT_TRUE(): assert board.board_id == "GENERIC_AGNOSTIC_BOARD" pin_true = digitalio.DigitalInOut(board.Dx_INPUT_TRUE) pin_true.direction = digitalio.Direction.INPUT - assert pin_true.value == True - assert pin_true.value == True # Test subsequent call does not change value + assert pin_true.value is True + assert pin_true.value is True # Test subsequent call does not change value pin_true.deinit() @@ -39,10 +39,10 @@ def test_Dx_INPUT_TRUE_PULL_DOWN(): assert board.board_id == "GENERIC_AGNOSTIC_BOARD" pin_true = digitalio.DigitalInOut(board.Dx_INPUT_TRUE) pin_true.direction = digitalio.Direction.INPUT - assert pin_true.value == True - assert pin_true.value == True # Test subsequent call does not change value + assert pin_true.value is True + assert pin_true.value is True # Test subsequent call does not change value pin_true.pull = digitalio.Pull.DOWN - assert pin_true.value == False + assert pin_true.value is False pin_true.deinit() @@ -51,10 +51,10 @@ def test_Dx_INPUT_FALSE_PULL_UP(): assert board.board_id == "GENERIC_AGNOSTIC_BOARD" pin_false = digitalio.DigitalInOut(board.Dx_INPUT_FALSE) pin_false.direction = digitalio.Direction.INPUT - assert pin_false.value == False - assert pin_false.value == False # Test subsequent call does not change value + assert pin_false.value is False + assert pin_false.value is False # Test subsequent call does not change value pin_false.pull = digitalio.Pull.UP - assert pin_false.value == False + assert pin_false.value is False pin_false.deinit() @@ -63,8 +63,8 @@ def test_Dx_INPUT_FALSE(): assert board.board_id == "GENERIC_AGNOSTIC_BOARD" pin_false = digitalio.DigitalInOut(board.Dx_INPUT_FALSE) pin_false.direction = digitalio.Direction.INPUT - assert pin_false.value == False - assert pin_false.value == False # Test subsequent call does not change value + assert pin_false.value is False + assert pin_false.value is False # Test subsequent call does not change value pin_false.deinit() @@ -73,8 +73,8 @@ def test_Dx_INPUT_TOGGLE(): assert board.board_id == "GENERIC_AGNOSTIC_BOARD" pin_toggle = digitalio.DigitalInOut(board.Dx_INPUT_TOGGLE) pin_toggle.direction = digitalio.Direction.INPUT - assert pin_toggle.value == True + assert pin_toggle.value is True assert ( - pin_toggle.value == False + pin_toggle.value is False ) # Test subsequent call does change value for this pin pin_toggle.deinit() diff --git a/tests/test_generic_agnostic_board_i2c.py b/tests/test_generic_agnostic_board_i2c.py index abb9e08..12136bd 100644 --- a/tests/test_generic_agnostic_board_i2c.py +++ b/tests/test_generic_agnostic_board_i2c.py @@ -12,6 +12,7 @@ def test_i2c_scan_random(): addr_list = i2c.scan() assert len(addr_list) == 3 for addr in addr_list: - assert addr >= 0x0 and addr <= 0x79 + assert addr >= 0x0 + assert addr <= 0x79 i2c.unlock() i2c.deinit()