From: thomas6g <30746275+thomas6g@users.noreply.github.com>
Date: Sun, 28 Feb 2021 16:15:47 +0000 (+0000)
Subject: Issue 423: FT232H Pin returns NotImplementedError
X-Git-Tag: 6.3.1~1^2~2
X-Git-Url: https://git.ayoreis.com/Adafruit_Blinka-hackapet.git/commitdiff_plain/79a1a7c38a3a62604c568e899a540a8312919726

Issue 423: FT232H Pin returns NotImplementedError

Class Pin of FT232H returns NotImplementedError if pull is not None, now.
Constants PULL_NONE, PULL_UP and PULL_DOWN are defined, now.
---

diff --git a/src/adafruit_blinka/microcontroller/ft232h/pin.py b/src/adafruit_blinka/microcontroller/ft232h/pin.py
index 94b8e14..6def23f 100644
--- a/src/adafruit_blinka/microcontroller/ft232h/pin.py
+++ b/src/adafruit_blinka/microcontroller/ft232h/pin.py
@@ -8,6 +8,9 @@ class Pin:
     OUT = 1
     LOW = 0
     HIGH = 1
+    PULL_NONE = 0
+    PULL_UP =  1
+    PULL_DOWN = 2
 
     ft232h_gpio = None
 
@@ -36,7 +39,7 @@ class Pin:
             raise RuntimeError("Can not init a None type pin.")
         # FT232H does't have configurable internal pulls?
         if pull:
-            raise ValueError("Internal pull up/down not currently supported.")
+            raise NotImplementedError("Internal pull up/down not currently supported.")
         pin_mask = Pin.ft232h_gpio.pins | 1 << self.id
         current = Pin.ft232h_gpio.direction
         if mode == self.OUT: