Ensure that the write_value passed into readinto is actually used, at least in busio.

diff --git a/src/adafruit_blinka/microcontroller/generic_linux/spi.py b/src/adafruit_blinka/microcontroller/generic_linux/spi.py
index b90587316536e105499e17d317a2073079b7fb18..a8141b96a0e84a0c90c1f5eab05502f8fede8754 100755 (executable)
--- a/src/adafruit_blinka/microcontroller/generic_linux/spi.py
+++ b/src/adafruit_blinka/microcontroller/generic_linux/spi.py
@@ -50,7 +50,7 @@ class SPI:
             print("Could not open SPI device - check if SPI is enabled in kernel!")
             raise
 
             print("Could not open SPI device - check if SPI is enabled in kernel!")
             raise
 

-    def readinto(self, buf, start=0, end=None):
+    def readinto(self, buf, start=0, end=None, write_value=0):

         if not buf:
             return
         if end is None:
         if not buf:
             return
         if end is None:


@@ -64,7 +64,7 @@ class SPI:
             self._spi.max_speed_hz = self.baudrate
             self._spi.mode = self.mode
             self._spi.bits_per_word = self.bits
             self._spi.max_speed_hz = self.baudrate
             self._spi.mode = self.mode
             self._spi.bits_per_word = self.bits

-            data = self._spi.readbytes(end-start)
+            data = self._spi.xfer([write_value]*(end-start))

             for i in range(end-start):  # 'readinto' the given buffer
               buf[start+i] = data[i]
             self._spi.close()
             for i in range(end-start):  # 'readinto' the given buffer
               buf[start+i] = data[i]
             self._spi.close()


@@ -77,7 +77,7 @@ class SPI:
         if not buffer_out or not buffer_in:
             return
         if out_end is None:
         if not buffer_out or not buffer_in:
             return
         if out_end is None:

-            out_end = len(buffer_out)        
+            out_end = len(buffer_out)

         if in_end is None:
             in_end = len(buffer_in)
         if out_end - out_start != in_end - in_start:
         if in_end is None:
             in_end = len(buffer_in)
         if out_end - out_start != in_end - in_start:

diff --git a/src/busio.py b/src/busio.py
index 45e36e4d64e8bc45f7925954a46b91a5f2feb2bf..8810fc4c8e6b9e45d4fd3cd365bebe193d1315fc 100755 (executable)
--- a/src/busio.py
+++ b/src/busio.py
@@ -129,7 +129,7 @@ class SPI(Lockable):
         return self._spi.write(buf, start, end)
 
     def readinto(self, buf, start=0, end=None, write_value=0):
         return self._spi.write(buf, start, end)
 
     def readinto(self, buf, start=0, end=None, write_value=0):

-        return self._spi.readinto(buf, start, end)
+        return self._spi.readinto(buf, start, end, write_value=write_value)

 
     def write_readinto(self, buffer_out, buffer_in,  out_start=0, out_end=None, in_start=0, in_end=None):
         return self._spi.write_readinto(buffer_out, buffer_in, out_start, out_end, in_start, in_end)
 
     def write_readinto(self, buffer_out, buffer_in,  out_start=0, out_end=None, in_start=0, in_end=None):
         return self._spi.write_readinto(buffer_out, buffer_in, out_start, out_end, in_start, in_end)