Untangle code and remove pylint disables

[Adafruit_Blinka-hackapet.git] / src / adafruit_blinka / microcontroller / nova / pin.py

diff --git a/src/adafruit_blinka/microcontroller/nova/pin.py b/src/adafruit_blinka/microcontroller/nova/pin.py
index 235e4ec749bd84cbf11b777864f37de15795510a..1fb4c9abe3fb5eb40e0a57e2cd7c764119bd6e02 100644 (file)
--- a/src/adafruit_blinka/microcontroller/nova/pin.py
+++ b/src/adafruit_blinka/microcontroller/nova/pin.py
@@ -1,11 +1,17 @@
+# SPDX-FileCopyrightText: 2021 Melissa LeBlanc-Williams for Adafruit Industries
+#
+# SPDX-License-Identifier: MIT
+"""Binho Nova pin names"""
+
+

 class Pin:
     """A basic Pin class for use with Binho Nova."""
 
 class Pin:
     """A basic Pin class for use with Binho Nova."""
 

-    IN = 'DIN'
-    OUT = 'DOUT'
-    AIN = 'AIN'
-    AOUT = 'AOUT'
-    PWM = 'PWM'
+    IN = "DIN"
+    OUT = "DOUT"
+    AIN = "AIN"
+    AOUT = "AOUT"
+    PWM = "PWM"

     LOW = 0
     HIGH = 1
 
     LOW = 0
     HIGH = 1
 


@@ -13,7 +19,11 @@ class Pin:
 
     def __init__(self, pin_id=None):
         if not Pin._nova:
 
     def __init__(self, pin_id=None):
         if not Pin._nova:

+            # pylint: disable=import-outside-toplevel

             from adafruit_blinka.microcontroller.nova import Connection
             from adafruit_blinka.microcontroller.nova import Connection

+
+            # pylint: enable=import-outside-toplevel
+

             Pin._nova = Connection.getInstance()
         # check if pin is valid
         if pin_id > 4:
             Pin._nova = Connection.getInstance()
         # check if pin is valid
         if pin_id > 4:


@@ -22,24 +32,27 @@ class Pin:
         self.id = pin_id
 
     def init(self, mode=IN, pull=None):
         self.id = pin_id
 
     def init(self, mode=IN, pull=None):

+        """Initialize the Pin"""

         if self.id is None:
             raise RuntimeError("Can not init a None type pin.")
         if self.id is None:
             raise RuntimeError("Can not init a None type pin.")

-        # Nova does't have configurable internal pulls for 
+        # Nova does't have configurable internal pulls for

         if pull:
             raise ValueError("Internal pull up/down not currently supported.")
         Pin._nova.setIOpinMode(self.id, mode)
 
     def value(self, val=None):
         if pull:
             raise ValueError("Internal pull up/down not currently supported.")
         Pin._nova.setIOpinMode(self.id, mode)
 
     def value(self, val=None):

+        """Set or return the Pin Value"""

         if self.id is None:
             raise RuntimeError("Can not access a None type pin.")
         # read
         if val is None:
         if self.id is None:
             raise RuntimeError("Can not access a None type pin.")
         # read
         if val is None:

-            return int(Pin._nova.getIOpinValue(self.id).split('VALUE ')[1])
+            return int(Pin._nova.getIOpinValue(self.id).split("VALUE ")[1])

         # write
         if val in (self.LOW, self.HIGH):
             Pin._nova.setIOpinValue(self.id, val)
         # write
         if val in (self.LOW, self.HIGH):
             Pin._nova.setIOpinValue(self.id, val)

-        else:
-            raise RuntimeError("Invalid value for pin")
+            return None
+        raise RuntimeError("Invalid value for pin")
+

 
 # create pin instances for each pin
 IO0 = Pin(0)
 
 # create pin instances for each pin
 IO0 = Pin(0)


@@ -69,4 +82,4 @@ UART1_TX = IO4
 UART1_RX = IO3
 
 # ordered as uartId, txId, rxId
 UART1_RX = IO3
 
 # ordered as uartId, txId, rxId

-uartPorts = ((0, UART1_TX, UART1_RX), )
+uartPorts = ((0, UART1_TX, UART1_RX),)