Untangle code and remove pylint disables

[Adafruit_Blinka-hackapet.git] / src / adafruit_blinka / microcontroller / tegra / t210 / pin.py

diff --git a/src/adafruit_blinka/microcontroller/tegra/t210/pin.py b/src/adafruit_blinka/microcontroller/tegra/t210/pin.py
index 8e3ad394963d3ef1ab1f07469aaffd4445e3dc2b..61c7ef61d1e1ac25ee31639c5eb9f915fd618701 100644 (file)
--- a/src/adafruit_blinka/microcontroller/tegra/t210/pin.py
+++ b/src/adafruit_blinka/microcontroller/tegra/t210/pin.py
@@ -1,11 +1,18 @@
-import sys
+# SPDX-FileCopyrightText: 2021 Melissa LeBlanc-Williams for Adafruit Industries
+#
+# SPDX-License-Identifier: MIT
+"""Tegra T210 pin names"""
+

 import atexit
 import atexit

-import Jetson.GPIO as GPIO
+from Jetson import GPIO
+

 GPIO.setmode(GPIO.TEGRA_SOC)
 GPIO.setmode(GPIO.TEGRA_SOC)

-GPIO.setwarnings(False)   # shh!
+GPIO.setwarnings(False)  # shh!
+

 
 

-# Pins dont exist in CPython so...lets make our own!

 class Pin:
 class Pin:

+    """Pins dont exist in CPython so...lets make our own!"""
+

     IN = 0
     OUT = 1
     LOW = 0
     IN = 0
     OUT = 1
     LOW = 0


@@ -28,7 +35,8 @@ class Pin:
         return self.id == other
 
     def init(self, mode=IN, pull=None):
         return self.id == other
 
     def init(self, mode=IN, pull=None):

-        if mode != None:
+        """Initialize the Pin"""
+        if mode is not None:

             if mode == self.IN:
                 self._mode = self.IN
                 GPIO.setup(self.id, GPIO.IN)
             if mode == self.IN:
                 self._mode = self.IN
                 GPIO.setup(self.id, GPIO.IN)


@@ -37,7 +45,7 @@ class Pin:
                 GPIO.setup(self.id, GPIO.OUT)
             else:
                 raise RuntimeError("Invalid mode for pin: %s" % self.id)
                 GPIO.setup(self.id, GPIO.OUT)
             else:
                 raise RuntimeError("Invalid mode for pin: %s" % self.id)

-        if pull != None:
+        if pull is not None:

             if self._mode != self.IN:
                 raise RuntimeError("Cannot set pull resistor on output")
             if pull == self.PULL_UP:
             if self._mode != self.IN:
                 raise RuntimeError("Cannot set pull resistor on output")
             if pull == self.PULL_UP:


@@ -48,82 +56,88 @@ class Pin:
                 raise RuntimeError("Invalid pull for pin: %s" % self.id)
 
     def value(self, val=None):
                 raise RuntimeError("Invalid pull for pin: %s" % self.id)
 
     def value(self, val=None):

-        if val != None:
+        """Set or return the Pin Value"""
+        if val is not None:

             if val == self.LOW:
                 self._value = val
                 GPIO.output(self.id, val)
             if val == self.LOW:
                 self._value = val
                 GPIO.output(self.id, val)

-            elif val == self.HIGH:
+                return None
+            if val == self.HIGH:

                 self._value = val
                 GPIO.output(self.id, val)
                 self._value = val
                 GPIO.output(self.id, val)

-            else:
-                raise RuntimeError("Invalid value for pin")
-        else:
-            return GPIO.input(self.id)
+                return None
+            raise RuntimeError("Invalid value for pin")
+        return GPIO.input(self.id)

 
 

+    # pylint: disable=no-method-argument

     @atexit.register
     def cleanup():
     @atexit.register
     def cleanup():

+        """Clean up pins"""

         print("Exiting... \nCleaning up pins")
         GPIO.cleanup()
 
         print("Exiting... \nCleaning up pins")
         GPIO.cleanup()
 

+    # pylint: enable=no-method-argument
+
+

 # Cannot be used as GPIO
 # Cannot be used as GPIO

-# before #
-#SDA = Pin('GEN1_I2C_SDA')
-#SCL = Pin('GEN1_I2C_SCL')
-#SDA_1 = Pin('GEN2_I2C_SDA')
-#SCL_1 = Pin('GEN2_I2C_SCL')
-
-# after #
-SDA = Pin('GEN2_I2C_SDA')
-SCL = Pin('GEN2_I2C_SCL')
-SDA_1 = Pin('GEN1_I2C_SDA')
-SCL_1 = Pin('GEN1_I2C_SCL')
+SDA = Pin("GEN1_I2C_SDA")
+SCL = Pin("GEN1_I2C_SCL")
+SDA_1 = Pin("GEN2_I2C_SDA")
+SCL_1 = Pin("GEN2_I2C_SCL")

 
 # These pins are native to TX1
 
 # These pins are native to TX1

-BB03 = Pin('GPIO_X1_AUD')
-X02 = Pin('MOTION_INT')
-H07 = Pin('AP_WAKE_NFC')
-E04 = Pin('DMIC3_CLK')
-U03 = Pin('UART1_CTS')
-U02 = Pin('UART1_RTS')
-B03 = Pin('DAP1_SCLK')
-B00 = Pin('DAP1_FS')
-B01 = Pin('DAP1_DIN')
-B02 = Pin('DAP1_DOUT')
-P17 = Pin('GPIO_EXP_P17')
-E05 = Pin('DMIC3_DAT')
-X00 = Pin('MODEM_WAKE_AP')
-P16 = Pin('GPIO_EXP_P16')
-X03 = Pin('ALS_PROX_INT')
+BB03 = Pin("GPIO_X1_AUD")
+X02 = Pin("MOTION_INT")
+H07 = Pin("AP_WAKE_NFC")
+E04 = Pin("DMIC3_CLK")
+U03 = Pin("UART1_CTS")
+U02 = Pin("UART1_RTS")
+B03 = Pin("DAP1_SCLK")
+B00 = Pin("DAP1_FS")
+B01 = Pin("DAP1_DIN")
+B02 = Pin("DAP1_DOUT")
+P17 = Pin("GPIO_EXP_P17")
+E05 = Pin("DMIC3_DAT")
+X00 = Pin("MODEM_WAKE_AP")
+P16 = Pin("GPIO_EXP_P16")
+X03 = Pin("ALS_PROX_INT")

 
 # These pins are native to NANO
 
 # These pins are native to NANO

-S05 = Pin('CAM_AF_EN')
-Z00 = Pin('GPIO_PZ0')
-V00 = Pin('LCD_BL_PW')
-G03 = Pin('UART2_CTS')
-G02 = Pin('UART2_RTS')
-J07 = Pin('DAP4_SCLK')
-J04 = Pin('DAP4_FS')
-J05 = Pin('DAP4_DIN')
-J06 = Pin('DAP4_DOUT')
-Y02 = Pin('LCD_TE')
-DD00 = Pin('SPI2_CS1')
-B07 = Pin('SPI2_CS0')
-B05 = Pin('SPI2_MISO')
-B04 = Pin('SPI2_MOSI')
-B06 = Pin('SPI2_SCK')
+S05 = Pin("CAM_AF_EN")
+Z00 = Pin("GPIO_PZ0")
+V00 = Pin("LCD_BL_PW")
+G03 = Pin("UART2_CTS")
+G02 = Pin("UART2_RTS")
+J07 = Pin("DAP4_SCLK")
+J04 = Pin("DAP4_FS")
+J05 = Pin("DAP4_DIN")
+J06 = Pin("DAP4_DOUT")
+Y02 = Pin("LCD_TE")
+DD00 = Pin("SPI2_CS1")
+B07 = Pin("SPI2_CS0")
+B05 = Pin("SPI2_MISO")
+B04 = Pin("SPI2_MOSI")
+B06 = Pin("SPI2_SCK")

 
 # These pins are shared across T210
 
 # These pins are shared across T210

-BB00 = Pin('AUD_MCLK')
-C04 = Pin('SPI1_CS1')
-C03 = Pin('SPI1_CS0')
-C01 = Pin('SPI1_MISO')
-C00 = Pin('SPI1_MOSI')
-C02 = Pin('SPI1_SCK')
-E06 = Pin('GPIO_PE6')
+BB00 = Pin("AUD_MCLK")
+C04 = Pin("SPI1_CS1")
+C03 = Pin("SPI1_CS0")
+C01 = Pin("SPI1_MISO")
+C00 = Pin("SPI1_MOSI")
+C02 = Pin("SPI1_SCK")
+E06 = Pin("GPIO_PE6")

 
 i2cPorts = (
 
 i2cPorts = (

-    (0, SCL, SDA), (1, SCL_1, SDA_1),
+    (0, SCL, SDA),
+    (1, SCL_1, SDA_1),

 )
 
 # ordered as spiId, sckId, mosiId, misoId
 spiPorts = ((0, C02, C00, C01), (1, B06, B04, B05))
 )
 
 # ordered as spiId, sckId, mosiId, misoId
 spiPorts = ((0, C02, C00, C01), (1, B06, B04, B05))

+
+# SysFS pwm outputs, pwm channel and pin in first tuple
+pwmOuts = (
+    ((0, 0), V00),
+    ((0, 1), E06),
+)